Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws#282 This fixes bug #282 #284

Merged
merged 13 commits into from
Jun 30, 2023
Merged

Aws#282 This fixes bug #282 #284

merged 13 commits into from
Jun 30, 2023

Conversation

sesmaili
Copy link
Contributor

What type of PR is this? bug

Which issue does this PR fix: #282

What does this PR do / Why do we need it: It fixes bug #282

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change: Yes

Automation added to e2e: N/A

Will this PR introduce any new dependencies?: No

Will this break upgrades or downgrades. Has updating a running cluster been tested?: No

Does this PR introduce any user-facing change?: No


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Jun 29, 2023

Pull Request Test Coverage Report for Build 5425788452

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.692%

Totals Coverage Status
Change from base Build 5415710026: 0.0%
Covered Lines: 3382
Relevant Lines: 10345

💛 - Coveralls

Copy link
Contributor

@mikhail-aws mikhail-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you squash commits into single one please to keep git history clean?
you can do for example:

git reset --soft aws:main
git commit -m ...

controllers/httproute_controller.go Outdated Show resolved Hide resolved
controllers/httproute_controller.go Show resolved Hide resolved
@solmonk
Copy link
Contributor

solmonk commented Jun 30, 2023

This type of approach looks okay for now, but in the long term, each condition type should be dealt separately, and only update the condition when the change is required. This way we can cover different types of statuses as well (addresses #277)

@sesmaili sesmaili removed the request for review from liwenwu-amazon June 30, 2023 18:14
@solmonk solmonk merged commit 6d52485 into aws:main Jun 30, 2023
@sesmaili sesmaili deleted the aws#282 branch June 30, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants