Fix service delete event #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5028410283
💛 - Coveralls |
| @@ -76,7 +76,7 @@ func (h *enqueueRequestsForEndpointsEvent) enqueueImpactedService(queue workqueu | |||
| } | |||
|
|
|||
| if err := h.client.Get(context.TODO(), namespaceName, svc); err != nil { | |||
| glog.V(2).Infof("enqueueImpactedService, service not found %v\n", err) | |||
| glog.V(2).Infof("Event: enqueueImpactedService, service not found %v\n", err) | |||
| @@ -29,6 +29,7 @@ func NewEqueueRequestServiceEvent(client client.Client) handler.EventHandler { | |||
|
|
|||
| func (h *enqueueRequetsForServiceEvent) Create(e event.CreateEvent, queue workqueue.RateLimitingInterface) { | |||
| service := e.Object.(*corev1.Service) | |||
| h.enqueueImpactedService(queue, service) | |||
There was a problem hiding this comment.
being consistent , can we add glog.V(6) here
| @@ -37,13 +38,34 @@ func (h *enqueueRequetsForServiceEvent) Update(e event.UpdateEvent, queue workqu | |||
|
|
|||
| func (h *enqueueRequetsForServiceEvent) Delete(e event.DeleteEvent, queue workqueue.RateLimitingInterface) { | |||
| service := e.Object.(*corev1.Service) | |||
| h.enqueueImpactedService(queue, service) | |||
controllers/service_controller.go
Outdated
| tgNameD := latticestore.TargetGroupName(svc.Name, svc.Namespace) | ||
| TGDeleted := ds.GetTargetGroupsByTG(tgNameD) | ||
| for _, tg := range TGDeleted { | ||
| glog.V(6).Infof("endpoints change trigger target IP list registration %v and tg %v\n", |
There was a problem hiding this comment.
Please update this debugging log line
| @@ -72,6 +81,38 @@ func Test_Targets(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Can you add a unit test to test service delete ?
There was a problem hiding this comment.
Unit test is covered at line 85-115
There was a problem hiding this comment.
also, can u add a new test for just service add without HTTProute stuff...
There was a problem hiding this comment.
Created issue for adding e2etest: #257
| @@ -72,6 +81,38 @@ func Test_Targets(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
| name: "Add all endpoints to build spec", | |||
There was a problem hiding this comment.
Please update this unit test to match what this unit test for?
|
LGTM. Please also add more detail on how you fixed the issue. Thanks |
liwenwu-amazon
approved these changes
May 22, 2023
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#237
What does this PR do / Why do we need it:
Fix
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
make e2etest
Manually run #257
Automation added to e2e:
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.