Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow creating namespaced K8S resources and update path based to use non-default gateway #228

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

liwenwu-amazon
Copy link
Contributor

@liwenwu-amazon liwenwu-amazon commented Apr 26, 2023

What type of PR is this?

feature
Which issue does this PR fix:
enhance e2e test framework to allow non-default namespaced gateway and httproute

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change:

Ran 2 of 2 Specs in 583.398 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIntegration (584.30s)
PASS
ok  	github.com/aws/aws-application-networking-k8s/test/suites/integration	584.329s

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@liwenwu-amazon liwenwu-amazon changed the title Add option to allow creating namespaced K8S resources Add option to allow creating namespaced K8S resources (working-in-progress) Apr 26, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4813571657

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.824%

Totals Coverage Status
Change from base Build 4812786807: 0.0%
Covered Lines: 3169
Relevant Lines: 9958

💛 - Coveralls

@liwenwu-amazon liwenwu-amazon changed the title Add option to allow creating namespaced K8S resources (working-in-progress) Add option to allow creating namespaced K8S resources and update path based to use non-default gateway Apr 26, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4814222172

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.824%

Totals Coverage Status
Change from base Build 4812786807: 0.0%
Covered Lines: 3169
Relevant Lines: 9958

💛 - Coveralls

Copy link
Contributor

@zijun726911 zijun726911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liwenwu-amazon liwenwu-amazon merged commit 0605797 into aws:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants