Add a capability that allow user to define a cluster local gateway #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4757967326
💛 - Coveralls |
liwenwu-amazon
changed the title
zijun726911
approved these changes
Apr 20, 2023
| ) | ||
|
|
||
| // TODO endpoint, region | ||
| var VpcID = "vpc-xxxx" | ||
| var AccountID = "yyyyyy" | ||
| var Region = "us-west-2" | ||
| var logLevel = defaultLogLevel | ||
| var DefaultServiceNetwork = NoDefaultServiceNetwork | ||
|
|
There was a problem hiding this comment.
Nit:
Could we remove NoDefaultServiceNetwork and just use:
var DefaultServiceNetwork = ""
if DefaultServiceNetwork == ""
That have better readability for me
zmingxi
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
What does this PR do / Why do we need it:
VPC Lattice today only allows VPC to associate to a single ServiceNetwork. But K8S users might desire to define multiple gateway(s) and associate HTTPRoutes to different gateway(s). And at meantime, K8S user want Pods in the cluster(s) to access their HTTPRoute(s) might belong to different gateway(s)
We add a capability to allow user to define a CLUSTER_LOCAL_GATEWAY where this CLUSTER_LOCAL_GATEWAY is associated to current VPC. And controller will automatically associate lattice service(HTTPRoute) to this CLUSTER_LOCAL_GATEWAY.
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
Automation added to e2e:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.