Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove random string prefix in LeaderElectionID #114

Merged
merged 1 commit into from
Mar 5, 2023
Merged

remove random string prefix in LeaderElectionID #114

merged 1 commit into from
Mar 5, 2023

Conversation

aaroniscode
Copy link
Contributor

Issue #, if available: N/A

Description of changes: remove the random string prefix in LeaderElectionID.

Before

» kubectl -n system get lease
NAME                             HOLDER                                                                         AGE
6288bc47.amazon-vpc-lattice.io   gateway-api-controller-7fcfcf96c8-d9chk_b8d441c3-7e84-4f70-866f-ae65dd229cd0   131m

After

» kubectl -n system get lease
NAME                             HOLDER                                                                         AGE
amazon-vpc-lattice.io            gateway-api-controller-7f6567978-6lkv7_4682e004-cef2-415f-8e8a-b283806f08ec    47m

For reference, here are some other related projects and their LeaderElectionID

  • EC2 ACK — ec2.services.k8s.aws
  • IAM ACK — iam.services.k8s.aws
  • AWS LB — aws-load-balancer-controller-leader
  • Karpenter — karpenter-leader-election

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@liwenwu-amazon liwenwu-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@liwenwu-amazon liwenwu-amazon merged commit 55cb9dd into aws:main Mar 5, 2023
@aaroniscode aaroniscode deleted the leader_election_id branch March 5, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants