Skip to content

Commit

Permalink
Change github-release.sh to substitute new version number in the gets…
Browse files Browse the repository at this point in the history
…tarted.md (#636)

Co-authored-by: Zijun Wang <[email protected]>
  • Loading branch information
zijun726911 and Zijun Wang authored May 15, 2024
1 parent 5365778 commit 31070fa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/guides/getstarted.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ This example creates a single cluster in a single VPC, then configures two HTTPR
aws ecr-public get-login-password --region us-east-1 | helm registry login --username AWS --password-stdin public.ecr.aws
helm upgrade gateway-api-controller \
oci://public.ecr.aws/aws-application-networking-k8s/aws-gateway-controller-chart \
--version=v1.0.4 \
--version=v1.0.5 \
--reuse-values \
--namespace aws-application-networking-system \
--set=defaultServiceNetwork=my-hotel
Expand Down Expand Up @@ -221,7 +221,7 @@ This section builds on the previous one. We will be migrating the Kubernetes `in
aws ecr-public get-login-password --region us-east-1 | helm registry login --username AWS --password-stdin public.ecr.aws
helm upgrade gateway-api-controller \
oci://public.ecr.aws/aws-application-networking-k8s/aws-gateway-controller-chart \
--version=v1.0.4 \
--version=v1.0.5 \
--reuse-values \
--namespace aws-application-networking-system \
--set=defaultServiceNetwork=my-hotel
Expand Down
1 change: 1 addition & 0 deletions scripts/github-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ sed_inplace "appVersion: $OLD_VERSION" "appVersion: $RELEASE_VERSION" "$WORKSPAC
sed_inplace "tag: $OLD_VERSION" "tag: $RELEASE_VERSION" "$WORKSPACE_DIR"/helm/values.yaml
sed_inplace "deploy-$OLD_VERSION.yaml" "deploy-$RELEASE_VERSION.yaml" "$WORKSPACE_DIR"/docs/guides/deploy.md
sed_inplace "--version=$OLD_VERSION" "--version=$RELEASE_VERSION" "$WORKSPACE_DIR"/docs/guides/deploy.md
sed_inplace "--version=$OLD_VERSION" "--version=$RELEASE_VERSION" "$WORKSPACE_DIR"/docs/guides/getstarted.md

# Build the deploy.yaml
make build-deploy
Expand Down

0 comments on commit 31070fa

Please sign in to comment.