Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to set retry-policy on App Mesh routes #66

Merged
merged 2 commits into from
Sep 25, 2019

Conversation

kiranmeduri
Copy link
Collaborator

@kiranmeduri kiranmeduri commented Sep 10, 2019

Issue #, if available:

Description of changes:
A retry policy enables clients to protect themselves from intermittent network failures or server-side failures. With retry policy definition user can control the retry logic used by Envoy proxies.

App Mesh CRD update checklist

  • Update aws-go-sdk in go.mod
  • Update CRD schema in deploy/all.yaml
  • Update CRD structs in pkg/apis/appmesh/v1beta1/types.go
  • Update deepcopy functions using make code-gen
  • Update App Mesh client wrapper pkg/aws/appmesh.go
  • Update controller(s) under pkg/controller/

Testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kiranmeduri kiranmeduri changed the title Added support to set retry-policy on App Mesh routes [DRAFT] Added support to set retry-policy on App Mesh routes Sep 10, 2019
@kiranmeduri kiranmeduri changed the title [DRAFT] Added support to set retry-policy on App Mesh routes Added support to set retry-policy on App Mesh routes Sep 12, 2019
@kiranmeduri kiranmeduri marked this pull request as ready for review September 12, 2019 20:18
@kiranmeduri
Copy link
Collaborator Author

fluxcd/flagger#303

Copy link
Contributor

@nckturner nckturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

A retry policy enables clients to protect themselves from intermittent
network failures or server-side failures. With retry policy definition
user can control the retry logic used by Envoy proxies.

This change includes

1. Update aws-go-sdk v1.23.18
2. Update VirtualService CRD definition to capture retry-policy via
3. Update controller to reconcile retry-policy with App Mesh resource
Action HttpRouteAction `json:"action"`
Match HttpRouteMatch `json:"match"`
Action HttpRouteAction `json:"action"`
RetryPolicy *HttpRetryPolicy `json:"retryPolicy,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add

// +optional

@nckturner nckturner merged commit e1f6c50 into aws:master Sep 25, 2019
@kiranmeduri kiranmeduri deleted the http-retry-policy branch August 10, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants