Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip node reconciliation to delete leaked ENIs on un-managed nodes #495

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

sushrk
Copy link
Contributor

@sushrk sushrk commented Nov 22, 2024

Issue #, if available:
N/A

Description of changes:
Skip node reconciliation to delete leaked branch ENIs on un-managed nodes. This unnecessarily re-queues node for reconciliation and results in repeating logs like-

{"level":"info","timestamp":"2024-11-22T00:06:42.703Z","logger":"node manager","msg":"reconciled cleanup node for leaking branch interfaces","NodeName":"ip-192-168-115-168.us-west-2.compute.internal","NextInterval":60,"NextReconciliationTime":"2024-11-22T00:07:42.703Z"}
{"level":"info","timestamp":"2024-11-22T00:08:41.963Z","logger":"branch eni provider","msg":"no trunk ENI is pointing to the given node","node":"ip-192-168-115-168.us-west-2.compute.internal","nodeName":"ip-192-168-115-168.us-west-2.compute.internal"}
{"level":"info","timestamp":"2024-11-22T00:08:41.963Z","logger":"node manager","msg":"reconciled cleanup node for leaking branch interfaces","NodeName":"ip-192-168-115-168.us-west-2.compute.internal","NextInterval":60,"NextReconciliationTime":"2024-11-22T00:09:41.963Z"}
{"level":"info","timestamp":"2024-11-22T00:08:41.963Z","logger":"branch eni provider","msg":"no trunk ENI is pointing to the given node","node":"ip-192-168-157-180.us-west-2.compute.internal","nodeName":"ip-192-168-157-180.us-west-2.compute.internal"}
{"level":"info","timestamp":"2024-11-22T00:08:41.963Z","logger":"node manager","msg":"reconciled cleanup node for leaking branch interfaces","NodeName":"ip-192-168-157-180.us-west-2.compute.internal","NextInterval":60,"NextReconciliationTime":"2024-11-22T00:09:41.963Z"}

Also cleaning up some log statements to help debug issues faster.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sushrk sushrk requested a review from a team as a code owner November 22, 2024 01:14
@sushrk sushrk changed the title skip node reconciliation for unmanaged nodes and cleanup logs skip node reconciliation to delete leaked ENIs on umanaged nodes Nov 22, 2024
@sushrk sushrk changed the title skip node reconciliation to delete leaked ENIs on umanaged nodes skip node reconciliation to delete leaked ENIs on un-managed nodes Nov 22, 2024
@sushrk sushrk merged commit c50b3b0 into aws:master Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants