Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.6 #483

Merged
merged 16 commits into from
Oct 22, 2024
Merged

Release 1.6 #483

merged 16 commits into from
Oct 22, 2024

Conversation

yash97
Copy link
Contributor

@yash97 yash97 commented Oct 10, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yash97 yash97 requested a review from a team as a code owner October 10, 2024 01:13
@yash97 yash97 changed the base branch from master to release-1.6 October 10, 2024 18:55
haouc
haouc previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@haouc haouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tzifudzi and others added 2 commits October 12, 2024 00:23
@tzifudzi @yash97
Add Windows secondary IP mode configurable options for managing IP ad…
141e4d0 
…dress allocation (aws#443)

* Add Windows secondary IP mode configurable options (aws#443)

aws#443

* Various code fixes for PR feedback

aws#443
@yash97
adding ctx in test
abea6fd
@tzifudzi
Copy link
Contributor

LGTM. I ran Windows e2e functional tests against the branch and all Windows tests passed.

@haouc haouc self-requested a review October 22, 2024 02:09
haouc
haouc approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@haouc haouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yash97 yash97 merged commit bbad908 into aws:release-1.6 Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haouc haouc haouc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yash97 @tzifudzi @haouc @jaydeokar