Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measure branch ENI operation latency in seconds #469

Merged
merged 1 commit into from
Sep 12, 2024
Merged

measure branch ENI operation latency in seconds #469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions pkg/provider/branch/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ var (
branchProviderOperationLatency = prometheus.NewSummaryVec(
prometheus.SummaryOpts{
Name: "branch_provider_operation_latency",
Help: "Branch Provider operations latency in ms",
Help: "Branch Provider operations latency in seconds",
Objectives: map[float64]float64{0: 0, 0.5: 0.05, 0.9: 0.01, 0.99: 0.001, 1: 0},
},
[]string{operationLabel, resourceCountLabel},
Expand Down Expand Up @@ -134,9 +134,9 @@ func prometheusRegister() {
}
}

// timeSinceMs returns the time since MS from the start time
func timeSinceMs(start time.Time) float64 {
return float64(time.Since(start).Milliseconds())
// timeSinceSeconds returns the time elapsed in seconds from the start time
func timeSinceSeconds(start time.Time) float64 {
return float64(time.Since(start).Seconds())
}

// InitResources initialized the resource for the given node name. The initialized trunk ENI is stored in
Expand Down Expand Up @@ -177,7 +177,7 @@ func (b *branchENIProvider) InitResource(instance ec2.EC2Instance) error {
branchProviderOperationsErrCount.WithLabelValues("init").Inc()
return fmt.Errorf("initializing trunk, %w", err)
}
branchProviderOperationLatency.WithLabelValues(operationInitTrunk, "1").Observe(timeSinceMs(start))
branchProviderOperationLatency.WithLabelValues(operationInitTrunk, "1").Observe(timeSinceSeconds(start))

// Add the Trunk ENI to cache if it does not already exist
if err := b.addTrunkToCache(nodeName, trunkENI); err != nil && err != ErrTrunkExistInCache {
Expand Down Expand Up @@ -372,7 +372,7 @@ func (b *branchENIProvider) CreateAndAnnotateResources(podNamespace string, podN
}

branchProviderOperationLatency.WithLabelValues(operationCreateBranchENI, strconv.Itoa(resourceCount)).
Observe(timeSinceMs(start))
Observe(timeSinceSeconds(start))

jsonBytes, err := json.Marshal(branchENIs)
if err != nil {
Expand Down Expand Up @@ -400,7 +400,7 @@ func (b *branchENIProvider) CreateAndAnnotateResources(podNamespace string, podN
fmt.Sprintf("Allocated %s to the pod", string(jsonBytes)), v1.EventTypeNormal)

branchProviderOperationLatency.WithLabelValues(operationAnnotateBranchENI, strconv.Itoa(resourceCount)).
Observe(timeSinceMs(start))
Observe(timeSinceSeconds(start))

log.Info("created and annotated branch interface/s successfully", "branches", branchENIs)

Expand Down
Loading