Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting PR 418 and syncing it with internal repo #462

Closed
wants to merge 58 commits into from
Closed

Reverting PR 418 and syncing it with internal repo #462

wants to merge 58 commits into from

Conversation

yash97
Copy link
Contributor

@yash97 yash97 commented Sep 3, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

  • updating config params:
    • --leader-elect
    • --metrics-bind-address
  • prometheus counter to count leaked cniNode resource
  • updating go version to 1.22
  • updating controller-gen to 0.v.14.0
  • Adding cooldown period for branch eni

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ysam12345 and others added 30 commits August 28, 2024 20:40
@ysam12345 @yash97
fix typo in document (aws#331)
ff33d53
@dependabot @yash97
Bump github.com/onsi/ginkgo/v2 from 2.12.1 to 2.13.0 (aws#322)
4346533 
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.12.1 to 2.13.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.12.1...v2.13.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@haouc @yash97
Update VPC CNI version and force vulns check using latest go version (a…
b94b068 
…ws#332)

* bump vpc cni version

* force vulns check to use specified go version
@dependabot @yash97
Bump github.com/onsi/gomega from 1.28.0 to 1.30.0 (aws#338)
3a7c1e2 
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.28.0 to 1.30.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.28.0...v1.30.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump golang.org/x/time from 0.3.0 to 0.5.0 (aws#339)
3b2ee3d 
Bumps [golang.org/x/time](https://github.com/golang/time) from 0.3.0 to 0.5.0.
- [Commits](golang/time@v0.3.0...v0.5.0)

---
updated-dependencies:
- dependency-name: golang.org/x/time
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump github.com/prometheus/common from 0.44.0 to 0.45.0 (aws#337)
f4a72cd 
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.44.0 to 0.45.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.44.0...v0.45.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@haouc @yash97
update supported EC2 instances (aws#340)
da4a300
@dependabot @yash97
Bump k8s.io/api from 0.28.3 to 0.28.4 (aws#336)
468eb44 
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.28.3 to 0.28.4.
- [Commits](kubernetes/api@v0.28.3...v0.28.4)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sushrk @haouc @yash97
Add support to configure branch ENI cooldown period via configmap (aw…
cd028ec 
…s#342)

* Add support to configure branch ENI cooldown period via configmap

* support configurable branch ENI cooldown period

* moving error check out from CM update

* Fix logs and remove mutex lock in Get function

* Update to go1.21.5

---------

Co-authored-by: Hao Zhou <[email protected]>
@haouc @yash97
manually update client-go in aligned with other dependencies (aws#341)
91057be
@haouc @yash97
fix the build issue
5588773
@sushrk @yash97
Update cooldown period in test (aws#344)
af90f63
@haouc @yash97
update debugging doc (aws#349)
23dd415
@dependabot @yash97
Bump github.com/google/uuid from 1.4.0 to 1.5.0 (aws#352)
31bfaa9 
Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/google/uuid/releases)
- [Changelog](https://github.com/google/uuid/blob/master/CHANGELOG.md)
- [Commits](google/uuid@v1.4.0...v1.5.0)

---
updated-dependencies:
- dependency-name: github.com/google/uuid
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump github.com/aws/aws-sdk-go from 1.45.19 to 1.49.13 (aws#353)
7ee59cc 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.45.19 to 1.49.13.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.45.19...v1.49.13)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump github.com/prometheus/client_model (aws#354)
9e88847 
Bumps [github.com/prometheus/client_model](https://github.com/prometheus/client_model) from 0.4.1-0.20230718164431-9a2bf3000d16 to 0.5.0.
- [Release notes](https://github.com/prometheus/client_model/releases)
- [Commits](https://github.com/prometheus/client_model/commits/v0.5.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_model
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump github.com/samber/lo from 1.38.1 to 1.39.0 (aws#355)
e95a9db 
Bumps [github.com/samber/lo](https://github.com/samber/lo) from 1.38.1 to 1.39.0.
- [Release notes](https://github.com/samber/lo/releases)
- [Changelog](https://github.com/samber/lo/blob/master/CHANGELOG.md)
- [Commits](samber/lo@v1.38.1...v1.39.0)

---
updated-dependencies:
- dependency-name: github.com/samber/lo
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump github.com/aws/amazon-vpc-cni-k8s from 1.15.3 to 1.16.0 (aws#356)
25057d2 
Bumps [github.com/aws/amazon-vpc-cni-k8s](https://github.com/aws/amazon-vpc-cni-k8s) from 1.15.3 to 1.16.0.
- [Release notes](https://github.com/aws/amazon-vpc-cni-k8s/releases)
- [Changelog](https://github.com/aws/amazon-vpc-cni-k8s/blob/master/CHANGELOG.md)
- [Commits](aws/amazon-vpc-cni-k8s@v1.15.3...v1.16.0)

---
updated-dependencies:
- dependency-name: github.com/aws/amazon-vpc-cni-k8s
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@haouc @yash97
add data race detection in test (aws#357)
e4ac94b
@sushrk @yash97
Update docs to add amazon-vpc-cni configmap options for SGPP and rela…
88c4669 
…ted troubleshooting (aws#359)
@haouc @yash97
add an node event example indicating cooldowm time windows has been u…
20c8069 
…pdated (aws#360)
@haouc @yash97
update README to provide instructions to check its version (aws#361)
acb1db7
@haouc @yash97
increase pod worker to 30 and update supported instance types list (a…
ac00002 
…ws#362)
@dependabot @yash97
Bump github.com/google/uuid from 1.5.0 to 1.6.0 (aws#364)
296e1fd 
Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/google/uuid/releases)
- [Changelog](https://github.com/google/uuid/blob/master/CHANGELOG.md)
- [Commits](google/uuid@v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/google/uuid
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump k8s.io/client-go from 0.28.4 to 0.29.1 (aws#366)
1fcce12 
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.28.4 to 0.29.1.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.28.4...v0.29.1)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump github.com/prometheus/common from 0.45.0 to 0.46.0 (aws#367)
59306ad 
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.45.0 to 0.46.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.45.0...v0.46.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump github.com/onsi/gomega from 1.30.0 to 1.31.1 (aws#365)
ee0d1ed 
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.30.0 to 1.31.1.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.30.0...v1.31.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump sigs.k8s.io/controller-runtime from 0.16.3 to 0.17.0 (aws#363)
4105de5 
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.16.3 to 0.17.0.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.16.3...v0.17.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jchen6585 @yash97
Increase windows test timeout (aws#368)
60d03c8 
Co-authored-by: Joseph Chen <[email protected]>
@sushrk @yash97
chore: migrate to kubebuilder v3 (aws#369)
eab29a4
haouc and others added 26 commits August 28, 2024 20:40
@haouc @yash97
rename windows flags (aws#371)
f2c3e9b
@sushrk @yash97
fix: paginate DescribeNetworkInterfaces with deep filters (aws#375)
604bc0b 
* fix: paginate DescribeNetworkInterfaces with deep filters

* update metrics and address review comments

* minor updates to address comments
@dependabot @yash97
Bump github.com/aws/aws-sdk-go from 1.49.13 to 1.50.29 (aws#380)
e4b7426 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.49.13 to 1.50.29.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.49.13...v1.50.29)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump k8s.io/client-go from 0.29.1 to 0.29.2 (aws#377)
0df4b12 
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.29.1 to 0.29.2.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.29.1...v0.29.2)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump github.com/prometheus/common from 0.46.0 to 0.49.0 (aws#378)
9a65750 
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.46.0 to 0.49.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.46.0...v0.49.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@xdu31 @yash97
Repo controlled build go version (aws#381)
b68a68d
@sushrk @yash97
update golang version (aws#383)
a86f654
@haouc @yash97
update protobuf to 1.33.0 (aws#387)
7affbf5
@haouc @yash97
pin envtest version due to an upstream bug (aws#390)
b2c8c68
@dependabot @yash97
Bump k8s.io/client-go from 0.29.2 to 0.29.3 (aws#392)
3b461d8 
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.29.2 to 0.29.3.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.29.2...v0.29.3)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump github.com/aws/amazon-vpc-cni-k8s from 1.16.0 to 1.17.1 (aws#393)
e50d431 
Bumps [github.com/aws/amazon-vpc-cni-k8s](https://github.com/aws/amazon-vpc-cni-k8s) from 1.16.0 to 1.17.1.
- [Release notes](https://github.com/aws/amazon-vpc-cni-k8s/releases)
- [Changelog](https://github.com/aws/amazon-vpc-cni-k8s/blob/master/CHANGELOG.md)
- [Commits](aws/amazon-vpc-cni-k8s@v1.16.0...v1.17.1)

---
updated-dependencies:
- dependency-name: github.com/aws/amazon-vpc-cni-k8s
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump github.com/prometheus/common from 0.49.0 to 0.51.1 (aws#395)
861ab3e 
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.49.0 to 0.51.1.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.49.0...v0.51.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @yash97
Bump github.com/aws/aws-sdk-go from 1.50.29 to 1.51.12 (aws#397)
384e4ad 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.50.29 to 1.51.12.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.50.29...v1.51.12)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sushrk @yash97
add github action to run gosec static analysis (aws#398)
51ff604 
* add github action to run gosec static analysis

* install gosec
@sushrk @yash97
update golang and dependency to fix CVE (aws#401)
668273d
@sushrk @yash97
revert pagination and call DescribeNetworkInterfaces with vpcID or su…
8bdd3b1 
…bnetID filter

* Revert "fix: paginate DescribeNetworkInterfaces with deep filters (aws#375)"

This reverts commit b5699de.

* call DescribeNetworkInterfaces with vpcID or subnetID filter
@haouc @yash97
update EC2 supported instance types (aws#402)
db8ccee
@haouc @yash97
add finalizer handler in v1.4
11f8292 
cr: https://code.amazon.com/reviews/CR-137885549
@haouc @yash97
fix an err variable
8e0b7c7 
cr: https://code.amazon.com/reviews/CR-141063909
@haouc @yash97
adding logs for mismatched CNINode
47bb479 
cr: https://code.amazon.com/reviews/CR-141072119
@haouc @yash97
add metrics for mismatches
8eb3b40 
cr: https://code.amazon.com/reviews/CR-141092975
@haouc @yash97
update EC2 instance types
a40fef5
@yash97
updating go version to 1.22 and controller gen version to 1.14.0
1c5b720
@yash97
Revert "Merge branch eni-cleanup into master"
34c74a2 
This reverts commit b5a054e.
@yash97
syncing master with internal 1.4.7
5b6edf6
@yash97
removing cni node test as part of revert PR
a2b03f5
@yash97 yash97 requested a review from a team as a code owner September 3, 2024 20:08
@yash97 yash97 closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yash97 @ysam12345 @haouc @sushrk @jchen6585 @xdu31