-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new CRD to delegate vpc resource requests #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definition looks good to me. I'll give others a chance to review before approving
b9e7e1d
to
848e231
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A couple of minor optional comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A couple of minor optional comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A couple of minor optional comments.
* add healthz subpathes for all controllers (#201) * support arch arg in dockerfile (#207) * updated vpc limits to include fields for hypervisor type and bare metal status (#217) * enable node events when instance type is not supported (#218) * Associate primary network interface SG with the trunk ENI when SG is not specified in ENIConfig (#221) * Associate primary network interface SG with the trunk ENI when SG is not specified in ENIConfig * add a new CRD to delegate vpc resource requests (#210) * upgrade controller runtime version (#227) * rebased onto master branch * fixed merge conflict --------- Co-authored-by: Hao Zhou <[email protected]> Co-authored-by: Sushmitha Ravikumar <[email protected]>
Issue #, if available:
Description of changes:
We want to add a new CRD to delegate communications between this controller and VPC CNI, or other operators from dataplane in the future.
Design considerations
Tests:
Created an object of the CRD
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.