Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logging of AllocIPAddresses #918

Closed
wants to merge 3 commits into from
Closed

improve logging of AllocIPAddresses #918

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8e1af2
improve AllocIPAddresses logging
pdbogen Apr 19, 2020
f5dbaf4
adjust log text
pdbogen Apr 19, 2020
64925b5
Merge remote-tracking branch 'upstream/master' into pdbogen-logging
pdbogen Apr 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/awsutils/awsutils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,16 +1106,18 @@ func (cache *EC2InstanceMetadataCache) AllocIPAddresses(eniID string, numIPs int
}

start := time.Now()
_, err = cache.ec2SVC.AssignPrivateIpAddresses(input)
output, err := cache.ec2SVC.AssignPrivateIpAddresses(input)
awsAPILatency.WithLabelValues("AssignPrivateIpAddresses", fmt.Sprint(err != nil)).Observe(msSince(start))
if err != nil {
log.Errorf("Failed to allocate a private IP addresses on ENI %v: %v", eniID, err)
awsAPIErrInc("AssignPrivateIpAddresses", err)
if containsPrivateIPAddressLimitExceededError(err) {
log.Debug("AllocIPAddresses: got PrivateIpAddressLimitExceeded")
return nil
}
return errors.Wrap(err, "allocate IP address: failed to allocate a private IP address")
}
log.Infof("AllocIPAddresses: allocated %d private IP addresses", len(output.AssignedPrivateIpAddresses))
return nil
}

Expand Down