Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock /proc/sys #870

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Mock /proc/sys #870

merged 1 commit into from
Mar 17, 2020

Conversation

anguslees
Copy link
Contributor

Add a mock for /proc/sys, to ease future testing.

@anguslees anguslees requested a review from mogren March 17, 2020 07:53
jaypipes
jaypipes approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failure on aarch64 build was the spurious cloudwatch unit test. all this looks good.

pkg/procsyswrapper/procsys.go

func (p *procSys) Set(key, value string) error {
return ioutil.WriteFile(p.path(key), []byte(value), 0644)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much cleaner code. thanks! :)

mogren
mogren approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot @anguslees

@mogren mogren merged commit 71538ac into aws:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogren mogren mogren approved these changes

@jaypipes jaypipes jaypipes approved these changes

Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anguslees @mogren @jaypipes