Minimal base image for cni-metrics-helper minimal base image #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
force-pushed
the
metrics_min_image
branch
2 times, most recently
from
9b23ff1 to
6fac830
Compare
jdn5126
force-pushed
the
metrics_min_image
branch
from
6fac830 to
c743f77
Compare
jdn5126
force-pushed
the
metrics_min_image
branch
2 times, most recently
from
321fe3d to
6b5426d
Compare
achevuru
reviewed
Jan 11, 2023
jdn5126
force-pushed
the
metrics_min_image
branch
from
6b5426d to
1d77de1
Compare
jdn5126
changed the title
jdn5126
force-pushed
the
metrics_min_image
branch
from
1d77de1 to
5933ef0
Compare
achevuru
reviewed
Jan 12, 2023
achevuru
previously approved these changes
Jan 12, 2023
jdn5126
force-pushed
the
metrics_min_image
branch
from
5933ef0 to
0ed6c97
Compare
jdn5126
force-pushed
the
metrics_min_image
branch
from
0ed6c97 to
ea18d4c
Compare
jdn5126
force-pushed
the
metrics_min_image
branch
from
ea18d4c to
06922f3
Compare
achevuru
approved these changes
Jan 23, 2023
jayanthvn
approved these changes
Jan 23, 2023
jdn5126
added a commit
to jdn5126/amazon-vpc-cni-k8s
that referenced
this pull request
Jan 24, 2023
jayanthvn
pushed a commit
that referenced
this pull request
Jan 24, 2023
rajeeshckr
added a commit
to rajeeshckr/amazon-vpc-cni-k8s
that referenced
this pull request
Mar 3, 2023
This reverts commit f0d5f91.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancement
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
This PR moves
cni-metrics-helperimage to be based on EKS minimal base image + glibc. This is needed to reduce the size of thecni-metrics-helperimage and to reduce the footprint for CVEs.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Manually updated images on running cluster and ran integration tests.
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
This will not break upgrades or downgrades. A running cluster has been tested.
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.