Update to add the Docker build files #3508

rsgrewal-aws · 2022-07-22T19:01:01Z

Description of changes: Added the files needed to review the docker build

Testing done: Completed it runs end to end

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

[x ] I have read the CONTRIBUTING doc and adhered to the example notebook best practices
[ x] I have updated any necessary documentation, including READMEs
[ x] I have tested my notebook(s) and ensured it runs end-to-end
[ x] I have linted my notebook(s) and code using tox -e black-format,black-nb-format

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

review-notebook-app · 2022-07-22T19:01:05Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

sagemaker-bot · 2022-07-22T19:04:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-link-check
Commit ID: 72e104f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T19:04:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-code-formatting
Commit ID: 72e104f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T19:04:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-code-formatting
Commit ID: 72e104f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T19:04:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-grammar
Commit ID: 72e104f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T19:04:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-grammar
Commit ID: 72e104f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T19:04:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-link-check
Commit ID: 72e104f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T19:04:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-link-check
Commit ID: 72e104f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T19:04:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-grammar
Commit ID: 72e104f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-22T19:05:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-code-formatting
Commit ID: 72e104f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

advanced_functionality/multi_model_catboost/container/dockerd-entrypoint.py

advanced_functionality/multi_model_catboost/container/model_handler.py

advanced_functionality/multi_model_catboost/container/dockerd-entrypoint.py

advanced_functionality/multi_model_catboost/container/model_handler.py

sagemaker-bot · 2022-07-22T19:14:51Z

AWS CodeBuild CI Report

CodeBuild project: amazon-sagemaker-examples-pr
Commit ID: 72e104f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jkroll-aws · 2022-07-22T21:43:58Z

advanced_functionality/multi_model_catboost/container/Dockerfile

+    python3 \
+    vim \
+    && rm -rf /var/lib/apt/lists/* \
+    && curl -O https://bootstrap.pypa.io/pip/3.6/get-pip.py \


Can you use python 3.7/3.8 since 3.6 is deprecated?

changed to 3.7

jkroll-aws · 2022-07-22T21:44:39Z

advanced_functionality/multi_model_catboost/container/dockerd-entrypoint.py

@@ -0,0 +1,30 @@
+import subprocess


Please try applying code formatting to the python files with black {file}.py

just updated in the latest commit

ran the latest black file

jkroll-aws · 2022-07-22T22:11:00Z

advanced_functionality/multi_model_catboost/multi_model_catboost.ipynb

@@ -0,0 +1,550 @@
+{


Branding nit: Catboost -> CatBoost (2-3 occurrences)

Typo: demostrate -> demonstrate (2 occurrences)

Grammar: show case -> showcase

Reply via ReviewNB

Thank you for catching this , have fixed in the latest push

jkroll-aws · 2022-07-22T22:11:00Z

advanced_functionality/multi_model_catboost/multi_model_catboost.ipynb

@@ -0,0 +1,550 @@
+{


Grammar nit: This include -> This includes

Reply via ReviewNB

fixed in the latest push

jkroll-aws · 2022-07-22T22:11:00Z

advanced_functionality/multi_model_catboost/multi_model_catboost.ipynb

@@ -0,0 +1,550 @@
+{


Typo: moels -> models

Reply via ReviewNB

Fixed in the latest push

…r file

sagemaker-bot · 2022-07-27T16:47:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-grammar
Commit ID: 9c368b1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T16:47:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-grammar
Commit ID: 9c368b1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T16:47:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-grammar
Commit ID: 9c368b1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T16:47:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-code-formatting
Commit ID: 9c368b1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T16:48:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-link-check
Commit ID: 9c368b1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T16:48:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-link-check
Commit ID: 9c368b1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T16:50:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-code-formatting
Commit ID: 9c368b1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T16:50:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-code-formatting
Commit ID: 9c368b1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T16:51:04Z

AWS CodeBuild CI Report

CodeBuild project: amazon-sagemaker-examples-pr
Commit ID: 9c368b1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T16:51:05Z

AWS CodeBuild CI Report

CodeBuild project: amazon-sagemaker-examples-pr
Commit ID: 3fdc90a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T16:51:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-examples-link-check
Commit ID: 9c368b1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rsgrewal-aws · 2022-07-28T23:43:06Z

made the required changes

rsgrewal-aws

made all the changes

rsgrewal-aws · 2022-07-28T23:31:28Z

advanced_functionality/multi_model_catboost/container/dockerd-entrypoint.py

@@ -0,0 +1,30 @@
+import subprocess


just updated in the latest commit

rsgrewal-aws · 2022-07-28T23:41:57Z

advanced_functionality/multi_model_catboost/container/Dockerfile

+    python3 \
+    vim \
+    && rm -rf /var/lib/apt/lists/* \
+    && curl -O https://bootstrap.pypa.io/pip/3.6/get-pip.py \


changed to 3.7

rsgrewal-aws · 2022-07-28T23:42:16Z

advanced_functionality/multi_model_catboost/container/dockerd-entrypoint.py

@@ -0,0 +1,30 @@
+import subprocess


ran the latest black file

rsgrewal-aws · 2022-07-28T23:42:26Z

advanced_functionality/multi_model_catboost/multi_model_catboost.ipynb

@@ -0,0 +1,550 @@
+{


rsgrewal-aws · 2022-07-28T23:42:34Z

advanced_functionality/multi_model_catboost/multi_model_catboost.ipynb

@@ -0,0 +1,550 @@
+{


rsgrewal-aws · 2022-07-28T23:42:40Z

advanced_functionality/multi_model_catboost/multi_model_catboost.ipynb

@@ -0,0 +1,550 @@
+{


marckarp and others added 9 commits June 29, 2022 06:17

Add CatBoost MME BYOC example

87eba70

formatted

e28c519

Resolving comment # 1 and 2

cc7ca4f

Resolving comment # 1 and 2

9339e0d

Resolving comment # 4

c0d8d12

Resolving clean up comment

d0168a1

Added comments about CatBoost and usage for MME

f3cb7e3

Reformatted the jupyter file

a343c12

Added the container with the relevant py files

72e104f

sagemaker-bot reviewed Jul 22, 2022

View reviewed changes

jkroll-aws reviewed Jul 22, 2022

View reviewed changes

rsgrewal-aws and others added 4 commits July 24, 2022 20:57

Added formatting using Black. Also fixed the comments from the Jupyte…

dd22211

…r file

Added formatting using Black. Also fixed the comments from the Jupyte…

3424c7b

…r file

Added formatting using Black. Also fixed the comments from the Jupyte…

195c365

…r file

Merge branch 'main' into main

9c368b1

atqy force-pushed the main branch from 3fdc90a to 9c368b1 Compare July 27, 2022 16:41

rsgrewal-aws commented Jul 28, 2022

View reviewed changes

jkroll-aws approved these changes Jul 29, 2022

View reviewed changes

jkroll-aws merged commit 2e8c261 into aws:main Jul 29, 2022

Update to add the Docker build files #3508

Update to add the Docker build files #3508

Conversation

rsgrewal-aws commented Jul 22, 2022

Merge Checklist

review-notebook-app bot commented Jul 22, 2022

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2022

AWS CodeBuild CI Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

rsgrewal-aws commented Jul 28, 2022

rsgrewal-aws left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment