Marketplace - Sample notebook templates for sellers #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Hi Aaron, I have addressed these two issues. |
aaronmarkham
suggested changes
Jul 17, 2020
...and_sample_notebook/Algorithm/Sample_Notebook_Template/title_of_your_product-Algorithm.ipynb
Outdated
Show resolved
Hide resolved
...and_sample_notebook/Algorithm/Sample_Notebook_Template/title_of_your_product-Algorithm.ipynb
Show resolved
Hide resolved
...and_sample_notebook/Algorithm/Sample_Notebook_Template/title_of_your_product-Algorithm.ipynb
Outdated
Show resolved
Hide resolved
...and_sample_notebook/Algorithm/Sample_Notebook_Template/title_of_your_product-Algorithm.ipynb
Outdated
Show resolved
Hide resolved
...and_sample_notebook/Algorithm/Sample_Notebook_Template/title_of_your_product-Algorithm.ipynb
Outdated
Show resolved
Hide resolved
Incorporating suggestions by @aaronmarkham Co-authored-by: Aaron Markham <[email protected]>
|
@aaronmarkham I have incorporated your and Kate's review comments. |
aaronmarkham
approved these changes
Jul 20, 2020
sunil19m
pushed a commit
to sunil19m/amazon-sagemaker-examples
that referenced
this pull request
Aug 4, 2020
* For sellers : Algorithms and ModelPackages sample notebook templates * fixing cosmetic issue * Renaming files, removing spaces in path * renaming files and folders * removing Excel and adding a markdown for describing listing requirements * Apply suggestions from code review Incorporating suggestions by @aaronmarkham Co-authored-by: Aaron Markham <[email protected]> * incorporating cosmetic changes suggested by @aaronmarkham * changing the AWS Marketplace reference in documentation * Fixing sample notebook TOC * incorporating Kate's review comments Co-authored-by: Waikar <[email protected]> Co-authored-by: Aaron Markham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
I would like to release sample notebook templates which AWS Marketplace sellers can use to craft the sample notebooks to be associated with their AWS Marketplace listings
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.