Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Your Own Model (k-means) - minor issue #340

Closed
samsammurphy opened this issue Jul 20, 2018 · 2 comments
Closed

Bring Your Own Model (k-means) - minor issue #340

samsammurphy opened this issue Jul 20, 2018 · 2 comments

Comments

@samsammurphy
Copy link
Contributor

This is a minor issue, when read the following cell..

Convert

The model format that Amazon SageMaker's k-means container expects is an MXNet NDArray

It might be helpful to the reader if the paragraph starts with a quick explanation, e.g. something like..

Convert

We created a container in advance and uploaded it to ECR using Sagemaker. You can upload a wide variety of containers. This one is setup to run the scikit learn k-means clustering algorithm and expects an MXNET NDArray ..

That is assuming I understood correctly (?)

Cheers

@djarpin
Copy link
Contributor

djarpin commented Jul 25, 2018

Hi @samsammurphy - "This one is setup to run the scikit learn k-means clustering algorithm" is not actually the case. The container this example points to is the Amazon SageMaker k-means container, which uses a different methodology than scikit k-means. The purpose of this notebook was to show how you could piggyback on the inference portion of a container that already exists. Hope that clears things up, but let me know if you have any questions. Thanks.

@samsammurphy
Copy link
Contributor Author

I see. Thanks!

atqy pushed a commit to atqy/amazon-sagemaker-examples that referenced this issue Aug 16, 2022
* add files for xgboost tree depth rule

* changed regex in tree_depth.py
atqy pushed a commit to atqy/amazon-sagemaker-examples that referenced this issue Aug 16, 2022
* Change setup.py

* Rename tornasole folder to smdebug

* Replace 'tornasole/' with 'smdebug/'

* Replace 'tornasole;' with 'smdebug;'

* Replace 'tornasole.' with 'smdebug.'

* Replace 'from tornasole import' with 'from smdebug import'

* Replace 'tornasole;' with 'smdebug;'

* Replace 'tornasole/' with 'smdebug/'

* Add isort

* Replace, without the file exclusions

* Disable tree depth tests since they're timing out on CI. Probably a bug in PR aws#340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants