Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zlib compression #66

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Zlib compression #66

merged 1 commit into from
Sep 14, 2020

Conversation

zackwine
Copy link
Contributor

@zackwine zackwine commented Sep 4, 2020

#26

Adds support for zlib compression.

See the example config below:

[SERVICE]
     Flush 20

[INPUT]
    Name        forward
    Listen      0.0.0.0
    Port        24224

[OUTPUT]
    Name            kinesis
    Match           *
    region          us-west-2
    stream          my-kinesis-stream-name
    compression     zlib
    append_newline  true

This will ensure individual records are zlib compressed as they are sent to Kinesis. This feature has been found to be compatible with the fluentd zlib compression (tested with the same decompression lambda we use in production).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zackwine zackwine requested a review from a team as a code owner September 4, 2020 14:19
Copy link
Contributor

@sonofachamp sonofachamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@sonofachamp sonofachamp requested a review from a team September 4, 2020 18:26
@PettitWesley
Copy link
Contributor

@zackwine Thank you!

@zackwine
Copy link
Contributor Author

zackwine commented Sep 9, 2020

Bump. Anything I can do to expedite getting a release with this feature?

FYI: Further load testing shows this will reduce record throughput by 20-40% when enabled (depending on concurrency configuration). This is expected given the additional CPU required to compress each record.

@PettitWesley
Copy link
Contributor

@zackwine Things are a bit tight right now... I will try to do a release this week for this + KPL if I can. Will let you know if anything is needed from you, but I think you're good.

@PettitWesley PettitWesley merged commit a28de66 into aws:mainline Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants