Experimental: Concurrently flush records in goroutines #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there a correctness tradeoff as well in that Fluent Bit will not be able to retry sending the data beyond what our plugin is capable of? It seems we're just returning an |
Fixes duplicate logs when kinesis limits are exceeded. Reduces the likelihood of dropped logs when kinesis provides backpressure (improvements in retries). Adds log messages to indicate when and how many records are dropped due to retry timeouts. Signed-off-by: Zack Wine <[email protected]>
Signed-off-by: Zack Wine <[email protected]>
Signed-off-by: Zack Wine <[email protected]>
|
Closing in favor of #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related to: fluent/fluent-bit#2159
Description of changes:
Previously, this plugin was synchronous. Since Fluent Bit is single-threaded, this decreases performance. Native C plugins in Fluent Bit core can take advantage of its event loop to asynchronously make requests. Go plugins are not as fancy. With this change, the plugin returns control to Fluent Bit immediately and sends data in a goroutine. I've previously verified that the goroutines are proper separate threads and continue running even after control returns to the Fluent Bit C code.
The downside to this change is that plugins will not accurately report errors or retries to Fluent Bit. I'm considering making this change an optional mode that is turned off by default and users can opt into if they want.
Long term of course, we will rewrite this plugin C and contribute it to the core of Fluent Bit, giving us performance and concurrency without the above drawback.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.