-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release script to download server sdk and package it alongside the tarball #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWSJackson
commented
Nov 30, 2023
levshaun-amzn
approved these changes
Nov 30, 2023
fzehao
approved these changes
Dec 1, 2023
levigerber
added a commit
that referenced
this pull request
Feb 9, 2024
* Update release script to download server sdk and package it alongside the tarball (#243) * Fix scripts to stop further execution when error occurs * Create common script for verifying working directory * Download and package server sdk with release script * Add some color to the release scripts * Add server sdk argument to readme commands * Use PowerShell standard commands instead of aliases in release script * Resolve root directory from release script path * Move release script artifacts to dedicated folders * Minor tweaks from PR comments * GLIFT-22897: fix anywhere fleet dropdown fleet name not show (#245) * Update readme on prereq to install dedicated server build support module (#246) * Update readme on prereq to install dedicated server build support module Co-authored-by: AWSJackson <[email protected]> --------- Co-authored-by: AWSJackson <[email protected]> * Remove spot fleet scenario (#247) * Minor Version Bump (#251) * GLIFT-23157: Patch Version Bump cr: https://code.amazon.com/reviews/CR-113158659 * Adds new changelog item * Changed to approved wording * Changes patch version bump to minor version bump --------- Co-authored-by: Levi Gerber <[email protected]> --------- Co-authored-by: AWSJackson <[email protected]> Co-authored-by: wenxiul <[email protected]> Co-authored-by: Levi Gerber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 2.x, we changed up the artifact we released from the tarball to a ZIP including the tarball, the CSharp Server SDK for Unity (with the license file removed), and a readme for installation instructions. This PR looks to update the scripts to handle this new artifact automatically.
Update release script to,
$LASTEXITCODE
to accurately stop execution of the script when an error occurs (at any level)& "$PSScriptRoot\build.ps1"
),$LASTEXITCODE
will not be set and the script won't terminate.npm pack
from including new artifact files (repeated calls toexport.ps1
would exponentially grow the tarball size)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.