Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release script to download server sdk and package it alongside the tarball #243

Merged
merged 9 commits into from
Dec 1, 2023

Conversation

AWSJackson
Copy link
Contributor

@AWSJackson AWSJackson commented Nov 21, 2023

With 2.x, we changed up the artifact we released from the tarball to a ZIP including the tarball, the CSharp Server SDK for Unity (with the license file removed), and a readme for installation instructions. This PR looks to update the scripts to handle this new artifact automatically.

Update release script to,

  • Accept a parameter for the server sdk version for the release
  • Download the server sdk, remove the license file, and re-package the zip
  • Package a zip including an installation readme, the server sdk zip, and the plugin tarball
  • Use $LASTEXITCODE to accurately stop execution of the script when an error occurs (at any level)
    • Known issue: If the error occurs with the call command itself (ex: & "$PSScriptRoot\build.ps1"), $LASTEXITCODE will not be set and the script won't terminate.
  • Prevent npm pack from including new artifact files (repeated calls to export.ps1 would exponentially grow the tarball size)
  • Add some color to the logs:
    • Green - Important step succeeded (building the sample project and packaging the release zip)
    • Yellow - Other step succeeded (clean up, intermediate build steps, etc.)
    • DarkYellow - Informational logs (identified plugin version, where to find sample project build logs)
    • Red - Most errors that occur
    • DarkRed - Important step failed (building the sample project)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AWSJackson AWSJackson merged commit 38bc340 into aws:develop Dec 1, 2023
levigerber added a commit that referenced this pull request Feb 9, 2024
* Update release script to download server sdk and package it alongside the tarball (#243)

* Fix scripts to stop further execution when error occurs

* Create common script for verifying working directory

* Download and package server sdk with release script

* Add some color to the release scripts

* Add server sdk argument to readme commands

* Use PowerShell standard commands instead of aliases in release script

* Resolve root directory from release script path

* Move release script artifacts to dedicated folders

* Minor tweaks from PR comments

* GLIFT-22897: fix anywhere fleet dropdown fleet name not show (#245)

* Update readme on prereq to install dedicated server build support module (#246)

* Update readme on prereq to install dedicated server build support module

Co-authored-by: AWSJackson <[email protected]>

---------

Co-authored-by: AWSJackson <[email protected]>

* Remove spot fleet scenario (#247)

* Minor Version Bump (#251)

* GLIFT-23157: Patch Version Bump

cr: https://code.amazon.com/reviews/CR-113158659

* Adds new changelog item

* Changed to approved wording

* Changes patch version bump to minor version bump

---------

Co-authored-by: Levi Gerber <[email protected]>

---------

Co-authored-by: AWSJackson <[email protected]>
Co-authored-by: wenxiul <[email protected]>
Co-authored-by: Levi Gerber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants