This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Let vendor choose which OTA backend to enable #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiutongs
previously approved these changes
Dec 13, 2019
tgsong
force-pushed
the
fix/ota_cmake
branch
2 times, most recently
from
4fbe974 to
6f517f7
Compare
tgsong
force-pushed
the
fix/ota_cmake
branch
from
6f517f7 to
db96ce0
Compare
|
/bot run checks |
pvyawaha
previously approved these changes
Dec 13, 2019
tgsong
changed the title
qiutongs
approved these changes
Dec 13, 2019
|
This looks like the kind of change which would require a documentation update? |
|
@cobusve Yes, I'll work with Robert to update this page, https://docs.aws.amazon.com/freertos/latest/portingguide/afr-porting-ota.html |
gkwicker
approved these changes
Dec 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We cannot automatically figure out which backend to enable in OTA. This PR refactors the OTA CMake file to let vendor choose which one to enable.
Checklist:
My code is Linted.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.