This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Change TooManySockets test to a concurrent count test #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/bot run checks |
alexa-noxon
approved these changes
Nov 7, 2019
pvyawaha
approved these changes
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old test returned pdPASS if integrationtestportableMAX_NUM_UNSECURE_SOCKETS sockets were created and pdFAIL for fewer or more sockets. Some ports are limited only by free memory. The test would return pdFAIL for those ports. To work around this an exclusion list was added via preprocessor directive.
This PR removes the exclusion list, and returns pdFAIL only if fewer sockets were created. The define directive is removed from ports without a hard limit. For those ports, the test looks for a reasonable number of sockets to be created.
https://amazon-freertos-ci.corp.amazon.com/job/master/job/custom_ide/439/