This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Refactor prvCheckoptions on master branch. #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2019 09:35
Refactor the function prvCheckOptions so that the two bodies of the two nested loops as functions replacing the loop bodies. This makes the code easier to read. It also makes it possible to prove the memory safety of the code with CBMC quickly.
…ons for CBMC proof. Also remove CBMC patch refactoring prvCheckOptions (this branch does the refactoring).
2 tasks
markrtuttle
requested review from
alexa-noxon,
dan4thewin,
dcgaws and
karkhaz
markrtuttle
changed the title
karkhaz
approved these changes
Oct 30, 2019
dcgaws
approved these changes
Oct 31, 2019
dan4thewin
approved these changes
Nov 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the TCP/IP header checking function prvCheckOptions. This refactoring replaces the loop bodies of the two nested loops with functions. This makes the code easier to read. It also makes it possible to prove the memory safety of prvCheckOptions with CBMC quickly: The functions representing the loop bodies are proved independently, and the result is used in the proof of prvCheckOptions itself.
This pull request was discussed and accepted by dcgaws and alexa-noxon (but never merged) as #259 (now closed) and #369 (now closed). The revisions of the pull request have simply reapplied the refactoring to master as master has evolved.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.