This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Add read long value test #1477
Merged
Add read long value test #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zshijing
force-pushed
the
ble_test_zshijing
branch
from
3a7d6c5 to
3129577
Compare
zshijing
force-pushed
the
ble_test_zshijing
branch
from
3129577 to
7f85fdc
Compare
|
/bot run checks |
1 similar comment
|
/bot run checks |
| BTStatus_t xStatus; | ||
| uint8_t LongReadBuffer[ bletests_LONG_WRITE_LEN ]; | ||
|
|
||
| memset( LongReadBuffer, 49, bletests_LONG_WRITE_LEN * sizeof( uint8_t ) ); |
There was a problem hiding this comment.
Instead of memset you can directly assign to {0} in the declaration above.
There was a problem hiding this comment.
Right now we just use the same value { '1', '1', '1', ...} that the long write test sent. It's easier to check the value on the RPi side.
| BTGattResponse_t xGattResponse; | ||
| BLETESTconfirmCallback_t xConfirmEvent; | ||
| BTStatus_t xStatus; | ||
| uint8_t LongReadBuffer[ bletests_LONG_WRITE_LEN ]; |
There was a problem hiding this comment.
bletests_LONG_WRITE_LEN - Can we have a separate define for the long reads, like bletests_LONG_READ_LEN
Also its better to not allocate long read buffer on stack, as it might over flow the stack buffer. Could be a static global variable instead.
ravibhagavandas
approved these changes
Nov 5, 2019
|
/bot run checks |
1 similar comment
|
/bot run checks |
pvyawaha
approved these changes
Nov 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.