Addition of disable-debug mode to ECS Logs Collector #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
reviewed
May 21, 2024
| if [ -e /etc/sysconfig/docker ]; then | ||
| case "${init_type}" in | ||
| systemd) | ||
| # sed -i 's/^OPTIONS="\(.*\)/OPTIONS="-D \1/g' /etc/sysconfig/docker |
There was a problem hiding this comment.
nit: lets remove this comment and L828
Comment on lines
+820
to
+821
| sed -i 's/\-D//g' /etc/sysconfig/docker | ||
| ok |
There was a problem hiding this comment.
this seems to be common to both cases (systemd and *). can we move this to be before the case and remove it here and L829 below?
Comment on lines
+852
to
+854
| if [ ! -d /etc/ecs ]; then | ||
| mkdir /etc/ecs | ||
| fi |
There was a problem hiding this comment.
if /etc/ecs doesn't exist then they don't have the ECS_LOGLEVEL=debug set in the config. wonder why we want to create the dir here ?
| mkdir /etc/ecs | ||
| fi | ||
|
|
||
| sed -i '/^\s*ECS_LOGLEVEL=debug/d' /etc/ecs/ecs.config |
There was a problem hiding this comment.
this sets the log level to debug, instead of unsetting it or setting it back to info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modification for #78
Implementation details
Details on #78
Testing
New tests cover the changes: No, Manually tested.
Licensing
This contribution is under the terms of the Apache 2.0 License: