Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade aws-sdk-go #83

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Upgrade aws-sdk-go #83

merged 1 commit into from
Apr 28, 2021

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Apr 28, 2021

Upgrading the AWS SDK fixes a problem when using an AWS profile which uses SSO:

before:

$ AWS_PROFILE=xxxxxxx ec2-instance-selector --memory 16 --vcpus 4
An error occurred when filtering instance types: NoCredentialProviders: no valid providers in chain. Deprecated.
	For verbose messaging see aws.Config.CredentialsChainVerboseErrors%

after:

$ AWS_PROFILE=xxxxxxx ~/go/bin/ec2-instance-selector --memory 16 --vcpus 4
d3en.xlarge
g4dn.xlarge
m4.xlarge
m5.xlarge
m5a.xlarge
...

Profile looks like this:

[profile xxxxxxx]
region = eu-west-1
output = json
csm_enabled = true
sso_start_url = https://d-xxxxxx.awsapps.com/start
sso_region = eu-west-1
sso_account_id = yyyyyyyyyyy
sso_role_name = zzzzzzzzz

Signed-off-by: Sylvain Rabot <[email protected]>
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@bwagner5 bwagner5 merged commit 4b79507 into aws:main Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants