-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On-Demand and Spot Price Retrieval Filters w/ a Cache #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love the new feature-- looks great on a first pass!
fb1902a
to
f614d6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome feature add 🔥 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🔥
Issue #, if available:
#71
Description of changes:
This update implements support for querying pricing data from the AWS Pricing API and the Amazon EC2 spot pricing history API. Users can now query for on-demand prices or avg spot price over the past 30 days. Pricing data can be displayed in the table output using
--output table-wide
. If no pricing criteria is specified as a filter, then pricing lookups are not performed since there is a pretty significant slow down.Examples:
Usage:
Filter On-Demand Price:
Filter Spot Price:
No Price Filter Specified w/ Table Output Wide:
We don't show the price when pricing filter is not specified because of the latency in retrieving pricing data. It would be nice to show it on a list operation, but the filtering engine does not know what type of output the user selected, it just aggregates, filters, and then returns the data. We might be able to make it a little smarter later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.