-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Services Support for EKS and EMR #72
Conversation
} | ||
|
||
func (EMR) getAllEMRInstanceTypes() []string { | ||
return []string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how often will this need to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure.... This is definitely not an optimal solution, but I think it'll be the best hack available. Other downsides are that users will have to actually update the ec2-instance-selector binary to get updated versions or to add supported instance types to older versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, if we see ourselves needing to manually update this list often then we could look into watching and/or pulling directly from the github readme on emr types
if version == "" { | ||
version = fallbackVersion | ||
} | ||
semanticVersion, err := semver.Make(version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oo nice 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍
Looks great! I was able to combine |
Issue #, if available:
#68
Description of changes:
TL;DR:
This PR adds support for arbitrary service filtering based on a simple service interface which transforms the user supplied filters (just like the aggregate filter functionality). This PR adds two implementations of services for EMR and EKS w/ versioning.
Example CLI usage:
Details:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.