Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat amd64 the same as x86_64 #35

Merged
merged 1 commit into from
Jul 20, 2020
Merged

treat amd64 the same as x86_64 #35

merged 1 commit into from
Jul 20, 2020

Conversation

bwagner5
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:

  • The EC2 API uses x86_64 to denote AMD64 architecture, but they are effectively the equivalent. Especially in the world of k8s, amd64 is used since golang uses amd64 as a GOARCH for building. In this PR, the selector pkg will accept x86_64 or amd64. If amd64 is passed in, it will be transformed when the rawFilters are executed to become x86_64 so that the EC2 API response matches.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bwagner5 bwagner5 requested a review from haugenj July 20, 2020 17:54
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2020

Codecov Report

Merging #35 into master will decrease coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   90.05%   89.85%   -0.21%     
==========================================
  Files           8        8              
  Lines         875      877       +2     
==========================================
  Hits          788      788              
- Misses         57       58       +1     
- Partials       30       31       +1     
Impacted Files Coverage Δ
pkg/selector/types.go 100.00% <ø> (ø)
pkg/selector/selector.go 84.50% <100.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be67b3f...4ec710b. Read the comment docs.

Copy link
Contributor

@haugenj haugenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants