Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower aggregate percent lower-band to reduce variance in instance resource specs #23

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Jul 9, 2020

Issue #, if available:
N/A

Description of changes:

  • lower aggregate percent lower-band to reduce variance in instance resource specs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files           8        8           
  Lines         875      875           
=======================================
  Hits          786      786           
  Misses         58       58           
  Partials       31       31           
Impacted Files Coverage Δ
pkg/selector/aggregates.go 92.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 594137b...ae82c2a. Read the comment docs.

Copy link
Contributor

@haugenj haugenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lower aggregate percent lower-band -> raise aggregate percent lower-band

@bwagner5 bwagner5 merged commit d98d38b into aws:master Jul 9, 2020
@bwagner5 bwagner5 deleted the lower-agg-percent branch July 15, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants