Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix removal of gpus from base-instance-type agg filter #22

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Jul 8, 2020

Issue #, if available:
N/A

Description of changes:

  • base-instance-type should filter out gpu instance types if the instance-type passed in is not a gpu instance-type.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bwagner5 bwagner5 requested a review from haugenj July 8, 2020 21:09
@codecov-commenter
Copy link

Codecov Report

Merging #22 into master will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   90.04%   89.82%   -0.22%     
==========================================
  Files           8        8              
  Lines         874      875       +1     
==========================================
- Hits          787      786       -1     
- Misses         57       58       +1     
- Partials       30       31       +1     
Impacted Files Coverage Δ
pkg/selector/aggregates.go 92.45% <100.00%> (+0.14%) ⬆️
pkg/selector/selector.go 84.36% <0.00%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b6ccee...dfb10cd. Read the comment docs.

Copy link
Contributor

@haugenj haugenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@bwagner5 bwagner5 merged commit 594137b into aws:master Jul 8, 2020
@bwagner5 bwagner5 deleted the fix-flexible branch July 15, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants