fix random behaviour in executeFilters #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#160, #162
Description of changes:
Sometimes (~3 / (100 * ~600 (instance types))), when all
exec
executions were finished, and:abort <- true
was fireddone <- true
was fired afterwg.Wait()
there was situation, that in select:
there were both cases to proceed, and then, according to specification:
I've merged
abort
anddone
channels into oneverdict
channel, and now, if someexec
will returnfalse
, it will be always ordered within shared channel before always lastverdict <- true
(after WaitGroup.Wait()).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.