Interactive table sorting, trimming, and filtering #152
Conversation
| @@ -62,30 +76,92 @@ func (m BubbleTeaModel) Init() tea.Cmd { | |||
| func (m BubbleTeaModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) { | |||
| switch msg := msg.(type) { | |||
| case tea.KeyMsg: | |||
| // don't listen for input if currently typing into text field | |||
| if m.tableModel.filterTextInput.Focused() { | |||
There was a problem hiding this comment.
What do you think about moving this table- and sorting-related logic to the respective view files, and then forwarding the key msg to the Update() of tableView and sortingView? Similar to the other "in focus" handling you do there.
There was a problem hiding this comment.
These if statements exist to prevent the keys used to switch between states from causing a state switch while typing in a text field.
| case "enter": | ||
| // sort and switch states to table | ||
| if m.currentState == stateSorting { | ||
| sortFilter := string(m.sortingModel.shorthandList.SelectedItem().(item)) |
There was a problem hiding this comment.
Similarly here, once we know we're in the sortingView state, we should pass the key msg to sortingView's update() and etc. to group all of the actual sorting logic together.
There was a problem hiding this comment.
For the sorting, information from the sorting state must be retrieved and then passed on to the table state before the state switch occurs. This requires access to both sortingModel and tableModel which are not currently reachable within the update() functions of each view.
I tried to keep all logic which dealt with "inter-state" affairs (such as switching states) in the Update() found in bubbletea.go, which is why the sorting logic currently lies there.
digocorbellini
force-pushed
the
better-table
branch
from
4e0da03 to
536fcab
Compare
|
The only reference to interactive mode in the README is kind of buried in the output flag's |
|
A short video demoing the features like you have in the PR (but combined and maybe 15-20 seconds) would be really cool on the readme! |
|
@bwagner5 @AustinSiu Added a demo video to the readme under the CLI examples. Change found here: 606ca51 |
Issue #, if available:
Description of changes:
Added three new features to the bubble tea table. They can be used both individually and at the same time. These changes are intended to make it easier to compare instance types without having to re-run instance selector.
1) Filtering rows by strings.
filtering_example.mov
Only rows containing the passed in string will be visible. Exists in
tableView.go2) Trimming rows to only selected rows
trimming_example.mov
Trim the visible rows to only show selected rows. Exists in
tableView.go3) Sorting
Sorting_Example.mov
Sort instance types using the same 2 methods available to CLI users: using shorthand flags (like memory, spot-price, etc.) or using a json path. Exists in
sortingView.goBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.