Verbose View for Interactive Output #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digocorbellini
commented
Aug 2, 2022
AustinSiu
reviewed
Aug 3, 2022
AustinSiu
approved these changes
Aug 4, 2022
| rows = append(rows, newRow) | ||
| switch m.currentState { | ||
| case stateTable: | ||
| return m.tableModel.view() |
There was a problem hiding this comment.
Looks much cleaner with the moving around, thanks! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Created an additional view for the
interactiveoutput option which displays all of the details of a selected instance type in JSON format (uses theVerboseInstanceTypeOutputfunction implemented inpkg/selector/outputs/outputs.goto format the instance type). This new view is reached by pressing "enter" on any highlighted row during theinteractiveoutput mode. The highlighted instance type will then be shown in detail in a horizontally and vertically resizable viewport.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
verbose_view_demo.mov