fix pricing sync issue #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LikithaVemulapalli
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#129
Description of changes:
On startup, the cache file is loaded, but all items could be expired. The expiration deletion isn't run initially on load, instead the cleanup interval is used to delete expired items. To use the cache, the number of items in the cache is expected to be non-zero, but the items could be non-zero and all expired. So first, this change deletes all expired items in the cache on initial load (which is synchronous). This change also adds a mutex to each pricing refresh so that bulk refreshes are prioritized over individual lookups.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.