GPU and Accelerator Model and Manufacturer Support w/ free-tier, auto-recovery, dedicated-hosts, and cpu-manufacturer #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rators and cpus, and freeTier, dedicatedHosts, and autoRecovery
bwagner5
changed the title
snay2
reviewed
Apr 11, 2022
| if contains(instanceTypeInfo.ProcessorInfo.SupportedArchitectures, ec2.ArchitectureTypeArm64) { | ||
| return aws.String("aws") | ||
| } | ||
| if amdRegex.Match([]byte(*instanceTypeInfo.InstanceType)) { |
There was a problem hiding this comment.
Regex matching the instance type seems fragile with all the possible current and future instance type names. Is that really the best (or only) way to suss out if the CPU is AMD?
There was a problem hiding this comment.
It is currently the only way to tell if a node is AMD :( But it's well documented in instance type names https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-types.html#:~:text=capabilities%2C%20such%20as%3A-,a%20%E2%80%93%20AMD%20processors,-g%20%E2%80%93%20AWS%20Graviton
snay2
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.