Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add caching for pricing and instance type data #110

Merged
merged 13 commits into from
Mar 18, 2022
Merged

add caching for pricing and instance type data #110

merged 13 commits into from
Mar 18, 2022

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Jan 3, 2022

Issue #, if available:
#74

Description of changes:

  • Break up the ec2pricing pkg with two supporting structs, one for OD pricing and the other for SpotPricing
  • Implement Caching on OD Pricing, Spot Pricing, and InstanceTypes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner January 3, 2022 22:29
@bwagner5 bwagner5 added the enhancement New feature or request label Jan 3, 2022
brycahta
brycahta reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple nits/questions, but awesome improvement overall and very clean

cmd/main.go Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
pkg/ec2pricing/ec2pricing.go Show resolved Hide resolved
pkg/ec2pricing/odpricing.go Show resolved Hide resolved
pkg/instancetypes/instancetypes.go Show resolved Hide resolved
@bwagner5 bwagner5 mentioned this pull request Feb 22, 2022
Closed
brycahta
brycahta approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm 🚀

@bwagner5 bwagner5 merged commit fac4741 into aws:main Mar 18, 2022
@ec2-bot ec2-bot mentioned this pull request Mar 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycahta brycahta brycahta approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwagner5 @brycahta