Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to stop accepting both of LogStream and LogStreamPrefix together #190

Merged

Conversation

hossain-rayhan
Copy link
Contributor

Signed-off-by: Rayhan Hossain [email protected]

Issue #, if available: #173

Description of changes:
This PR will stop the output plugin to accept LogStreamName and LogStreamPrefix together. This is an invalid use case and the plugin should return an error.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hossain-rayhan hossain-rayhan requested a review from a team as a code owner August 2, 2021 06:23
Copy link
Contributor

@PettitWesley PettitWesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub says it needs to be rebased

@hossain-rayhan hossain-rayhan force-pushed the stream-prefix-validation branch from 3e85f8a to a8d5798 Compare August 2, 2021 17:11
@hossain-rayhan hossain-rayhan merged commit d7fdadf into aws:mainline Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants