Add default fallback log group and stream names #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can update the go version. We should first update it here and check the build: https://github.com/aws/aws-for-fluent-bit/blob/master/Dockerfile.plugins#L1 And then update the build.yml for all the plugins: https://github.com/aws/amazon-cloudwatch-logs-for-fluent-bit/blob/mainline/.github/workflows/build.yml#L19 |
|
very strange.... I'm not sure what was causing the above error, but |
cloudwatch/cloudwatch.go
Outdated
|
|
||
| if len(e.group) > maxGroupStreamLength { | ||
| e.group = output.defaultLogGroupName | ||
| logrus.Errorf("[cloudwatch %d] parsing log_group_name template '%s': %v", |
There was a problem hiding this comment.
may be add- "will use default group name" ?
PettitWesley
approved these changes
Oct 28, 2020
PettitWesley
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #99
Description of changes:
This adds two new input variables to the plugin with defaulted static values. These variables represent fallback group and stream names that get used any time a
$(variable)in one of the templated inputs fails to parse.The build failed with these errors:
The
%wverb requires go 1.13 or newer. Requires this: aws/aws-for-fluent-bit#87By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.