Use correct cgroup path for tasks which with long task ARN format #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
There are two formats of ECS task ARN as following. Currently, customer can opt-in the new ARN format.
Previously, if a task is with new ARN format, it will also contain "cluster-name" in its cgroup path, which is expected by CWAgent. But it is no longer the case after ECS Agent get upgraded. (According to this PR). Thus if customer launch a ECS cluster with latest ECS Agent, there is no "cluster-name" in its cgroup path which cause CWAgent fail to read cgroup stats.
Description of changes
This PR will make CWAgent to attempt to read task cgroup path without the "cluster-name" first. And fallback to read task cgroup path with the "cluster-name" in case for customers who are still using old version of ECS Agent.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Test the CWAgent in latest ECS cluster with new ARN format enabled & disabled.