-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add allowlist in cadvisor file system extractor to avoid extra logs #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxaws
reviewed
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the internal link ” cr https://code.amazon.com/reviews/CR-28383980“?
Should we add "fix: " to the commit message?
yimuniao
force-pushed
the
master
branch
2 times, most recently
from
June 26, 2020 04:01
5940e6d
to
d6a3801
Compare
Fixed |
sethAmazon
pushed a commit
that referenced
this pull request
Aug 11, 2022
* Basic functionality for backend transmitter removed unit tests playing around with github changed package name seperated the test case reformatted removed seperate test changed package new IntegrationTest Setup fixed integrationTest.yml applied pr feedback: -added new stored data called "CommitDate" -reorganized code -updated code to go v2 -changed metrics struct cleaned workflow init auto run typo auto test cleanworkflow init added performance test to integrationTest changed epoch time to int -after that became an issue in frontend Delete fastPerformanceTest.yml Added PR requested changes and comments backend Fix * go mod tidy update * Workflow (#5) * concurrent workflow added *update item added *release detection added * edited test * added pt to master * remove extra vars * go mod tidy * fixed imports * import bug * fixed value bug * updated iam roles * New workflow (#8) * fixed sendItem nil map error * added concurreny retrying * fixed no value bug * fixed value bug * demo-4 * demo 1 * Fix debug logging and revert Windows ctl script PS1 changes (#516) * change to use fmt * Revert "Using cmd/c to avoid PowerShell ISE does not accept stderr (#473)" This reverts commit 89d1912. * remove log entirely * update release notes * Performance Benchmarking Log monitor and TPS tests (#513) * added concurrent log monitoring/writing to test and tests several combinations of # of logs monitored and different tps * fixed call to StartLogWrite * restructured json packet to send to database. CWA configs are now generated at runtime. log number is given as an environment variable so tests can run concurrently, so commented code is included for that change * rewrote how databse entry packets are crafted/create, defer log stream/group deletions, addressed other small pr comments * removed extra metrics from CWA config * separated delete log group and streams so they can be called separately, but kept the original function definition as to not break other code. removed bad calls to DeleteLogGroupAndStreams * testing with _GAVIN'S_ code * debug print check * changed parser * testing with concurrency version * changeg setenv to string * added comments Co-authored-by: Andrew Huynh <[email protected]> Co-authored-by: gmealy1 <[email protected]> * demo-0 * test for pr * testing running performance test on prev. releases * test 1 * test - 2 pRPT * genMatrix test * test * test * t * t * t * te * test * test * test * test * test * test * test * t * t * testing hard coded * full test w 3 old releases * test * testing with default * redid terraform for previousData.yml * debugging * test binary making * trying with new terraform * try * testing new terraform with git stash * forgot comma * one more comma :/ * sha to old_sha * testing getting releases on workflow * same * test * t * no formatting * git show --tags * trying with sep shell script * trying .sh directly * log cat * :/ * git * git show --tags * trying query tag * git fetch * git fetch w show * simplify * git tests * query * git describe tags * :( * not shallow * query t * testing * t * 3 test * testing update config * added concurrent update release tag * try2 * Testing releases from 1627262978 to 1658798978 * working release * Testing releases from 1627262978 to 1653934651 * Testing releases from 1622398651 to 1653934651 * Testing releases from to * Testing releases from Sun May 30 18:17:31 UTC 2021 to Mon May 30 18:17:31 UTC 2022 * Testing releases from 20210530 to 20220530 * updated shell * Testing releases from 2021/05/30 to 2022/05/30 * updated previousData.yml * fixed stoplocal dep * generator duplicate fix * fixed the assume role in env * Testing releases from 2021/05/30 to 2022/05/30 * testing Co-authored-by: Andrew Huynh <[email protected]> Co-authored-by: gmealy1 <[email protected]>
sethAmazon
added a commit
that referenced
this pull request
Aug 11, 2022
* Basic functionality for backend transmitter removed unit tests playing around with github changed package name seperated the test case reformatted removed seperate test changed package new IntegrationTest Setup fixed integrationTest.yml applied pr feedback: -added new stored data called "CommitDate" -reorganized code -updated code to go v2 -changed metrics struct cleaned workflow init auto run typo auto test cleanworkflow init added performance test to integrationTest changed epoch time to int -after that became an issue in frontend Delete fastPerformanceTest.yml Added PR requested changes and comments backend Fix * go mod tidy update * Workflow (#5) * concurrent workflow added *update item added *release detection added * edited test * added pt to master * remove extra vars * go mod tidy * fixed imports * import bug * fixed value bug * updated iam roles * New workflow (#8) * fixed sendItem nil map error * added concurreny retrying * fixed no value bug * fixed value bug * demo-4 * demo 1 * Fix debug logging and revert Windows ctl script PS1 changes (#516) * change to use fmt * Revert "Using cmd/c to avoid PowerShell ISE does not accept stderr (#473)" This reverts commit 89d1912. * remove log entirely * update release notes * Performance Benchmarking Log monitor and TPS tests (#513) * added concurrent log monitoring/writing to test and tests several combinations of # of logs monitored and different tps * fixed call to StartLogWrite * restructured json packet to send to database. CWA configs are now generated at runtime. log number is given as an environment variable so tests can run concurrently, so commented code is included for that change * rewrote how databse entry packets are crafted/create, defer log stream/group deletions, addressed other small pr comments * removed extra metrics from CWA config * separated delete log group and streams so they can be called separately, but kept the original function definition as to not break other code. removed bad calls to DeleteLogGroupAndStreams * testing with _GAVIN'S_ code * debug print check * changed parser * testing with concurrency version * changeg setenv to string * added comments Co-authored-by: Andrew Huynh <[email protected]> Co-authored-by: gmealy1 <[email protected]> * demo-0 * test for pr * testing running performance test on prev. releases * test 1 * test - 2 pRPT * genMatrix test * test * test * t * t * t * te * test * test * test * test * test * test * test * t * t * testing hard coded * full test w 3 old releases * test * testing with default * redid terraform for previousData.yml * debugging * test binary making * trying with new terraform * try * testing new terraform with git stash * forgot comma * one more comma :/ * sha to old_sha * testing getting releases on workflow * same * test * t * no formatting * git show --tags * trying with sep shell script * trying .sh directly * log cat * :/ * git * git show --tags * trying query tag * git fetch * git fetch w show * simplify * git tests * query * git describe tags * :( * not shallow * query t * testing * t * 3 test * testing update config * added concurrent update release tag * try2 * Testing releases from 1627262978 to 1658798978 * working release * Testing releases from 1627262978 to 1653934651 * Testing releases from 1622398651 to 1653934651 * Testing releases from to * Testing releases from Sun May 30 18:17:31 UTC 2021 to Mon May 30 18:17:31 UTC 2022 * Testing releases from 20210530 to 20220530 * updated shell * Testing releases from 2021/05/30 to 2022/05/30 * updated previousData.yml * fixed stoplocal dep * generator duplicate fix * fixed the assume role in env * Testing releases from 2021/05/30 to 2022/05/30 * testing Co-authored-by: Andrew Huynh <[email protected]> Co-authored-by: gmealy1 <[email protected]> Co-authored-by: okankoAMZ <[email protected]> Co-authored-by: Andrew Huynh <[email protected]> Co-authored-by: gmealy1 <[email protected]>
sethAmazon
pushed a commit
that referenced
this pull request
Aug 15, 2022
* Basic functionality for backend transmitter removed unit tests playing around with github changed package name seperated the test case reformatted removed seperate test changed package new IntegrationTest Setup fixed integrationTest.yml applied pr feedback: -added new stored data called "CommitDate" -reorganized code -updated code to go v2 -changed metrics struct cleaned workflow init auto run typo auto test cleanworkflow init added performance test to integrationTest changed epoch time to int -after that became an issue in frontend Delete fastPerformanceTest.yml Added PR requested changes and comments backend Fix * go mod tidy update * Workflow (#5) * concurrent workflow added *update item added *release detection added * edited test * added pt to master * remove extra vars * go mod tidy * fixed imports * import bug * fixed value bug * updated iam roles * New workflow (#8) * fixed sendItem nil map error * added concurreny retrying * fixed no value bug * fixed value bug * demo-4 * demo 1 * Fix debug logging and revert Windows ctl script PS1 changes (#516) * change to use fmt * Revert "Using cmd/c to avoid PowerShell ISE does not accept stderr (#473)" This reverts commit 89d1912. * remove log entirely * update release notes * Performance Benchmarking Log monitor and TPS tests (#513) * added concurrent log monitoring/writing to test and tests several combinations of # of logs monitored and different tps * fixed call to StartLogWrite * restructured json packet to send to database. CWA configs are now generated at runtime. log number is given as an environment variable so tests can run concurrently, so commented code is included for that change * rewrote how databse entry packets are crafted/create, defer log stream/group deletions, addressed other small pr comments * removed extra metrics from CWA config * separated delete log group and streams so they can be called separately, but kept the original function definition as to not break other code. removed bad calls to DeleteLogGroupAndStreams * testing with _GAVIN'S_ code * debug print check * changed parser * testing with concurrency version * changeg setenv to string * added comments Co-authored-by: Andrew Huynh <[email protected]> Co-authored-by: gmealy1 <[email protected]> * demo-0 * test for pr * testing running performance test on prev. releases * test 1 * test - 2 pRPT * genMatrix test * test * test * t * t * t * te * test * test * test * test * test * test * test * t * t * testing hard coded * full test w 3 old releases * test * testing with default * redid terraform for previousData.yml * debugging * test binary making * trying with new terraform * try * testing new terraform with git stash * forgot comma * one more comma :/ * sha to old_sha * testing getting releases on workflow * same * test * t * no formatting * git show --tags * trying with sep shell script * trying .sh directly * log cat * :/ * git * git show --tags * trying query tag * git fetch * git fetch w show * simplify * git tests * query * git describe tags * :( * not shallow * query t * testing * t * 3 test * testing update config * added concurrent update release tag * try2 * Testing releases from 1627262978 to 1658798978 * working release * Testing releases from 1627262978 to 1653934651 * Testing releases from 1622398651 to 1653934651 * Testing releases from to * Testing releases from Sun May 30 18:17:31 UTC 2021 to Mon May 30 18:17:31 UTC 2022 * Testing releases from 20210530 to 20220530 * updated shell * Testing releases from 2021/05/30 to 2022/05/30 * updated previousData.yml * fixed stoplocal dep * generator duplicate fix * fixed the assume role in env * Testing releases from 2021/05/30 to 2022/05/30 * testing * updated the performance test to most recent * only use s3 not make build * Testing releases from 2022/06/01 to 2022/08/01 * added debug param * Testing releases from 2022/07/06 to 2022/08/01 * Testing releases from 2021/05/30 to 2022/05/30 * Testing releases from 2022/06/01 to 2022/08/01 * Testing releases from 2022/06/01 to 2022/08/01 * export fix in terraform * terraform typo * formatting changes * add print statement * export added to tpdate release * typo fix * Testing releases from 2021/05/30 to 2022/05/30 Co-authored-by: Andrew Huynh <[email protected]> Co-authored-by: gmealy1 <[email protected]>
sethAmazon
pushed a commit
that referenced
this pull request
Aug 16, 2022
* Basic functionality for backend transmitter removed unit tests playing around with github changed package name seperated the test case reformatted removed seperate test changed package new IntegrationTest Setup fixed integrationTest.yml applied pr feedback: -added new stored data called "CommitDate" -reorganized code -updated code to go v2 -changed metrics struct cleaned workflow init auto run typo auto test cleanworkflow init added performance test to integrationTest changed epoch time to int -after that became an issue in frontend Delete fastPerformanceTest.yml Added PR requested changes and comments backend Fix * go mod tidy update * Workflow (#5) * concurrent workflow added *update item added *release detection added * edited test * added pt to master * remove extra vars * go mod tidy * fixed imports * import bug * fixed value bug * updated iam roles * New workflow (#8) * fixed sendItem nil map error * added concurreny retrying * fixed no value bug * fixed value bug * demo-4 * demo 1 * Fix debug logging and revert Windows ctl script PS1 changes (#516) * change to use fmt * Revert "Using cmd/c to avoid PowerShell ISE does not accept stderr (#473)" This reverts commit 89d1912. * remove log entirely * update release notes * Performance Benchmarking Log monitor and TPS tests (#513) * added concurrent log monitoring/writing to test and tests several combinations of # of logs monitored and different tps * fixed call to StartLogWrite * restructured json packet to send to database. CWA configs are now generated at runtime. log number is given as an environment variable so tests can run concurrently, so commented code is included for that change * rewrote how databse entry packets are crafted/create, defer log stream/group deletions, addressed other small pr comments * removed extra metrics from CWA config * separated delete log group and streams so they can be called separately, but kept the original function definition as to not break other code. removed bad calls to DeleteLogGroupAndStreams * testing with _GAVIN'S_ code * debug print check * changed parser * testing with concurrency version * changeg setenv to string * added comments Co-authored-by: Andrew Huynh <[email protected]> Co-authored-by: gmealy1 <[email protected]> * demo-0 * test for pr * testing running performance test on prev. releases * test 1 * test - 2 pRPT * genMatrix test * test * test * t * t * t * te * test * test * test * test * test * test * test * t * t * testing hard coded * full test w 3 old releases * test * testing with default * redid terraform for previousData.yml * debugging * test binary making * trying with new terraform * try * testing new terraform with git stash * forgot comma * one more comma :/ * sha to old_sha * testing getting releases on workflow * same * test * t * no formatting * git show --tags * trying with sep shell script * trying .sh directly * log cat * :/ * git * git show --tags * trying query tag * git fetch * git fetch w show * simplify * git tests * query * git describe tags * :( * not shallow * query t * testing * t * 3 test * testing update config * added concurrent update release tag * try2 * Testing releases from 1627262978 to 1658798978 * working release * Testing releases from 1627262978 to 1653934651 * Testing releases from 1622398651 to 1653934651 * Testing releases from to * Testing releases from Sun May 30 18:17:31 UTC 2021 to Mon May 30 18:17:31 UTC 2022 * Testing releases from 20210530 to 20220530 * updated shell * Testing releases from 2021/05/30 to 2022/05/30 * updated previousData.yml * fixed stoplocal dep * generator duplicate fix * fixed the assume role in env * Testing releases from 2021/05/30 to 2022/05/30 * testing * updated the performance test to most recent * only use s3 not make build * Testing releases from 2022/06/01 to 2022/08/01 * added debug param * Testing releases from 2022/07/06 to 2022/08/01 * Testing releases from 2021/05/30 to 2022/05/30 * Testing releases from 2022/06/01 to 2022/08/01 * Testing releases from 2022/06/01 to 2022/08/01 * export fix in terraform * terraform typo * formatting changes * add print statement * export added to tpdate release * typo fix * Testing releases from 2021/05/30 to 2022/05/30 * Testing releases from 2022/07/01 to 2022/08/01 * Testing releases from 2022/07/01 to 2022/08/01 * Testing releases from 2022/07/01 to 2022/08/01 * Testing releases from 2022/07/01 to 2022/08/01 * Testing releases from 2022/07/24 to 2022/08/01 * Testing releases from 2022/07/24 to 2022/08/01 * Testing releases from 2022/07/27 to 2022/08/01 * Testing releases from 2022/07/27 to 2022/08/01 * trying hard code version * dep fix * Testing releases from 2021/05/30 to 2022/05/30 Co-authored-by: Andrew Huynh <[email protected]> Co-authored-by: gmealy1 <[email protected]>
sethAmazon
pushed a commit
to sethAmazon/amazon-cloudwatch-agent
that referenced
this pull request
Oct 27, 2022
Add telegraf_ prefix to plugin names in translated yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.