-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support both for onPremise and onPrem within interal binaries #532
Conversation
Codecov Report
@@ Coverage Diff @@
## master #532 +/- ##
==========================================
- Coverage 57.03% 56.77% -0.27%
==========================================
Files 373 374 +1
Lines 17665 17760 +95
==========================================
+ Hits 10076 10083 +7
- Misses 6999 7085 +86
- Partials 590 592 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. |
@@ -106,7 +106,8 @@ amazon-cloudwatch-agent-config-wizard: copy-version-file | |||
$(LINUX_AMD64_BUILD)/amazon-cloudwatch-agent-config-wizard github.com/aws/amazon-cloudwatch-agent/cmd/amazon-cloudwatch-agent-config-wizard | |||
$(LINUX_ARM64_BUILD)/amazon-cloudwatch-agent-config-wizard github.com/aws/amazon-cloudwatch-agent/cmd/amazon-cloudwatch-agent-config-wizard | |||
$(WIN_BUILD)/amazon-cloudwatch-agent-config-wizard.exe github.com/aws/amazon-cloudwatch-agent/cmd/amazon-cloudwatch-agent-config-wizard | |||
$(DARWIN_BUILD)/amazon-cloudwatch-agent-config-wizard github.com/aws/amazon-cloudwatch-agent/cmd/amazon-cloudwatch-agent-config-wizard | |||
$(DARW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a visual bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed that in old commit and its not shown for me with newest commit https://github.com/aws/amazon-cloudwatch-agent/pull/532/files. So yes might be a visual bug
Duplicate of #543 |
Close #474
Description of the issue
Support both onPrem and onPremise for config translator due to breaking changes
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
For testing, building binaries from external repo and implement the changes:
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make linter