Upload Integration Test Binary To S3 Instead Of Building On EC2 Fixes… #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethAmazon
force-pushed
the
use-s3-binary
branch
2 times, most recently
from
eb22f82 to
542be44
Compare
aateeqi
reviewed
Feb 18, 2022
sethAmazon
force-pushed
the
use-s3-binary
branch
from
542be44 to
3f57e27
Compare
|
Why you are at it, please delete these two variables and replace it with |
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 57.16% 57.41% +0.24%
==========================================
Files 370 369 -1
Lines 17246 17151 -95
==========================================
- Hits 9859 9847 -12
+ Misses 6809 6726 -83
Partials 578 578
Continue to review full report at Codecov.
|
sethAmazon
force-pushed
the
use-s3-binary
branch
from
3f57e27 to
bb487cc
Compare
sethAmazon
force-pushed
the
use-s3-binary
branch
from
bb487cc to
8e60377
Compare
|
I'll close this pr and just add this as a part of an effort to add more ami we support for testing |
sethAmazon
pushed a commit
to sethAmazon/amazon-cloudwatch-agent
that referenced
this pull request
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#364)
Description of the issue
Reduce time it takes to run the integration tests by only building once.
Description of changes
Upload binary to s3 instead of build on ec2
Tests
Ran the integration tests on my fork