Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov file browser fix #311

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Codecov file browser fix #311

merged 3 commits into from
Nov 11, 2021

Conversation

jhnlsn
Copy link
Contributor

@jhnlsn jhnlsn commented Nov 10, 2021

Description of the issue

Unable to view files on codecov

Description of changes

Sets the correct base path to find files on github

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Describe what tests you have done.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #311 (6b1fdd0) into master (fb9873e) will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
- Coverage   57.20%   56.91%   -0.30%     
==========================================
  Files         355      356       +1     
  Lines       16291    16386      +95     
==========================================
+ Hits         9320     9326       +6     
- Misses       6426     6515      +89     
  Partials      545      545              
Impacted Files Coverage Δ
amazon-cloudwatch-agent/tool/data/config.go
...ch-agent/plugins/processors/ec2tagger/ebsvolume.go
...slate/metrics/metrics_collect/collectd/collectd.go
...s/metrics_collect/collectd/ruleCollectDAuthFile.go
...t/plugins/outputs/cloudwatchlogs/cloudwatchlogs.go
...n-cloudwatch-agent/plugins/inputs/awscsm/filter.go
...ugins/inputs/prometheus_scraper/metrics_handler.go
...nslate/metrics/metrics_collect/cpu/ruleTotalCpu.go
...slator/translate/metrics/ruleForceFlushInterval.go
...atch-agent/translator/translate/metrics/metrics.go
... and 701 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9873e...6b1fdd0. Read the comment docs.

SaxyPandaBear
SaxyPandaBear previously approved these changes Nov 10, 2021
Copy link
Contributor

@SaxyPandaBear SaxyPandaBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this lowered coverage but LGTM

@jhnlsn
Copy link
Contributor Author

jhnlsn commented Nov 10, 2021

that change fixed it on my fork, but for some reason not here. I'm going to do away with the running inside the folder. not exactly sure why that was done in the first place.

@SaxyPandaBear
Copy link
Contributor

I remember commenting on that before, because the action went into that folder in every step with a cd, so I suggested just using the working directory

@jhnlsn
Copy link
Contributor Author

jhnlsn commented Nov 11, 2021

@SaxyPandaBear ready for review

Copy link
Contributor

@SaxyPandaBear SaxyPandaBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhnlsn jhnlsn merged commit 01fce72 into master Nov 11, 2021
@SaxyPandaBear SaxyPandaBear deleted the codecov-file-viewer branch July 25, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants