Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Nightly Builds #291

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Upload Nightly Builds #291

merged 1 commit into from
Oct 14, 2021

Conversation

sethAmazon
Copy link
Contributor

Description of the issue

Upload nightly builds to s3

Description of changes

Add git hub action to upload binaries to s3 nightly

Tests

Github action set up on my fork

@jhnlsn
Copy link
Contributor

jhnlsn commented Oct 7, 2021

I thought -failfast would fail the build when the first test fails. It seems to be running all tests even if one fails, making it really difficult to find the FAIL.

@jhnlsn
Copy link
Contributor

jhnlsn commented Oct 7, 2021

First of all, this is awesome! Glad we are taking this direction!

I've seen a lot of projects that release nightly builds, most recently I saw that telegraf releases nightlies: https://github.com/influxdata/telegraf/blob/master/docs/NIGHTLIES.md

  • A couple of things need to be decided before we roll out something like where we are going to store these builds.
  • A readme page that fully outlines that nightly builds are not production ready and should be used at own risk
  • Break out artifacts into their own consumables. Separate files for downloading deb/rpm/raw binaries.
  • Use tar.gz instead of zip for everything but windows artifact :)

@sethAmazon sethAmazon force-pushed the nightly-build branch 10 times, most recently from 194afed to 7f9d71c Compare October 12, 2021 20:23
@sethAmazon
Copy link
Contributor Author

We spoke about the changes offline. Update the pr

.github/workflows/nightly-build.yml Outdated Show resolved Hide resolved
.github/workflows/nightly-build.yml Outdated Show resolved Hide resolved
@sethAmazon sethAmazon force-pushed the nightly-build branch 5 times, most recently from a8b53ff to 155539c Compare October 12, 2021 21:19
adam-mateen
adam-mateen previously approved these changes Oct 12, 2021
.github/workflows/nightly-build.yml Show resolved Hide resolved
@sethAmazon sethAmazon merged commit 0a249e6 into aws:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants