Removed runc dependency #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced with golang os/user lookup and version/arch specific setUid/setGid.
jhnlsn
reviewed
Oct 5, 2021
|
Should we wait on this until we can upgrade to using 1.17 for release? |
sethAmazon
reviewed
Oct 5, 2021
|
I don't really think there's a need to wait. The only difference would be the inclusion of the two 1.15 specific files, which can easily be removed once 1.15 is no longer supported. |
sethAmazon
reviewed
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The agent has a dependency on
github.com/opencontainers/runc v1.0.0-rc10, which requires an upgrade. While the version could be bumped up tov1.0.0-rc95, that would affect the dependency ongithub.aaakk.us.kg/google/cadvisor v0.36.0, which depends onv1.0.0-rc10. Without updating the cadvisor dependency, which would require more evaluation and incremental changes, the next best step would be to remove the local dependency.See #254 for more details.
Description of changes
Removed dependency on runc in userutil_linux.
Replaced with golang os/user lookup and version/arch specific setUid/setGid.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Tested on EC2 linux instance. Added unit test for
getGroupIds.