Adding new metrics: pod_cpu_usage_total and pod_memory_working_set #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good to me. Can you update the integ test to validate these new metrics then attach test result? |
Closed
Merged
Merged
There is an issue with fetching other metrics in integration Tests, so the complete workflow is not successful: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/10408457860/job/28826102473 |
movence
approved these changes
Aug 16, 2024
sky333999
reviewed
Aug 16, 2024
sky333999
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adding 2 new ContainerInsights metrics which will be used for gaining cost visibility for customers using Enhanced CI:
pod_cpu_usage_totalpod_memory_working_setLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Deployed the image in test account to validate that the metrics are being emitted.