Deprecate runtime tag #1275
Merged
Deprecate runtime tag #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into deprecate-runtime-tag
sky333999
approved these changes
Aug 8, 2024
jefchien
approved these changes
Aug 8, 2024
mitali-salvi
added a commit
that referenced
this pull request
Aug 8, 2024
This reverts commit bcecbc1.
mitali-salvi
added a commit
that referenced
this pull request
Aug 8, 2024
This reverts commit bcecbc1.
This was referenced Aug 8, 2024
Merged
mitali-salvi
added a commit
to mitali-salvi/amazon-cloudwatch-agent
that referenced
this pull request
Dec 2, 2024
This reverts commit bcecbc1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Neuron devices when being utilized by multiple processes linked to it, this led to emitting metrics per runtime tag giving a false sense of average utilization.
Note, the changes need to be re-based after the PR is merged -> #1262
Description of changes
We drop the runtime tag from the filter logic and default it to aggregate in memory for this case
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint