Adding append_dimension for ethtool in schema #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you attach the json config you were using for your testing and a screenshot of what the metrics look like in CloudWatch? |
sky333999
reviewed
Jun 4, 2024
okankoAMZ
reviewed
Jun 4, 2024
musa-asad
previously approved these changes
Jun 7, 2024
sethAmazon
previously approved these changes
Jun 7, 2024
sky333999
reviewed
Jun 7, 2024
translator/translate/metrics/metrics_collect/ethtool/ethtool.go
Outdated
Show resolved
Hide resolved
sky333999
reviewed
Jun 7, 2024
musa-asad
previously approved these changes
Jun 7, 2024
sky333999
reviewed
Jun 7, 2024
translator/translate/metrics/metrics_collect/ethtool/ethtool.go
Outdated
Show resolved
Hide resolved
sky333999
approved these changes
Jun 7, 2024
musa-asad
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Currently users are not able to have append dimensions to ethtool because the current schema fails since it doesn't have a append_dimension in ethtooldefinitions.
Description of changes
Simple fix to this was to add the append_dimension section to ethtooldefinition. We also needed to change the ApplyRule for Ethtool in order to account for using the append_dimensions input.
Ethtool metrics with added dimensions:
Agent configuration used:
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Describe what tests you have done.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint